stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/attachments/media/CaptureMediaLauncher.kt (1)

66-72: Consider restructuring to avoid a conditional composable call.

The ?: return null on line 68 means rememberLauncherForActivityResult is only called when contract is non-null. This is a conditional composable invocation: if photo/video transitions between (false, false) and a valid combination while this composable is in the tree, the slot for rememberLauncherForActivityResult is reset. While this was pre-existing and photo/video are unlikely to change at runtime, it's generally safer to always call rememberLauncherForActivityResult and return null after the fact, or to guard the call site so rememberCaptureMediaLauncher is only called when at least one mode is true.

An alternative that always invokes the composable:

♻️ Suggested restructure

 `@Composable`
 public fun rememberCaptureMediaLauncher(
     photo: Boolean,
     video: Boolean,
     onResult: (File) -> Unit,
 ): ManagedActivityResultLauncher<Unit, File?>? {
-    val contract = remember(photo, video) {
-        resolveMediaPickerMode(photo, video)?.let { CaptureMediaContract(it) }
-    } ?: return null
-    return rememberLauncherForActivityResult(contract) { file ->
+    val mode = remember(photo, video) { resolveMediaPickerMode(photo, video) }
+    val contract = remember(mode) { mode?.let { CaptureMediaContract(it) } }
+    val launcher = contract?.let {
+        rememberLauncherForActivityResult(it) { file ->
             file?.let(onResult)
         }
+    }
+    return launcher
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/attachments/media/CaptureMediaLauncher.kt`
around lines 66 - 72, Compute val mode = resolveMediaPickerMode(photo, video)
via remember(photo, video) and always call rememberLauncherForActivityResult
with a non-null ActivityResultContract instance (e.g., construct a
CaptureMediaContract using mode when non-null, or pass a harmless dummy
CaptureMediaContract when mode is null) so rememberLauncherForActivityResult is
invoked unconditionally; then, after creating the launcher, return null if mode
is null, otherwise return the launcher that forwards results to onResult. Make
sure to reference resolveMediaPickerMode, CaptureMediaContract,
rememberLauncherForActivityResult, and the local contract/mode variable so the
composable call is not conditionally skipped.